[Mesa-dev] [PATCH 09/21] i965: Extract is_dword test

Matt Turner mattst88 at gmail.com
Tue Dec 23 10:41:11 PST 2014


On Mon, Dec 22, 2014 at 7:29 PM, Ben Widawsky
<benjamin.widawsky at intel.com> wrote:
> As it turns out, I have other uses for this tiny convenience function. Simple
> extraction for use by others. Matt was right for not liking the macro in the
> initial patch.
>
> While doing this, add it to a few easy to spot users of this functionality.

I don't really think this is clearer. I'd just prefer to check for
D/UD, especially in cases where they're in a compound conditional with
a check for F as well.

I'd just get rid of the IS_DWORD macro completely.


More information about the mesa-dev mailing list