[Mesa-dev] [PATCH 2/2] i965: Copy shader->shadow_samplers to prog->ShadowSamplers.

Matt Turner mattst88 at gmail.com
Wed Dec 31 20:51:18 PST 2014


On Wed, Dec 31, 2014 at 8:04 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> ir_to_mesa does this - apparently we just forgot or something.
>
> Without this, we'll guess the wrong texture swizzle (XYZW for color
> instead of XXX1 for depth) when doing precompiles.
>
> This cuts 26 shader recompiles in a time demo of "Counter Strike:
> Global Offensive" (58 -> 32) on Sandybridge.  Haswell still has 0
> recompiles.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87886
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---

Nice work, Ken. Both are

Reviewed-by: Matt Turner <mattst88 at gmail.com>

I think this is a pretty good example of how important users' feedback
is. We probably wouldn't have discovered this otherwise.


More information about the mesa-dev mailing list