[Mesa-dev] [PATCH] i965: Delete stale "pre-gen4" comment in texture validation code.

Eric Anholt eric at anholt.net
Sat Feb 1 12:43:11 PST 2014


Kenneth Graunke <kenneth at whitecape.org> writes:

> On 02/01/2014 01:42 AM, Chris Forbes wrote:
>> I wonder if we could lose mt->first_level entirely? It looks like it's
>> always going to be zero in i965 now.
>
> Oh wow, I hadn't noticed that.  It looks like you're right, except maybe
> in one case...intel_renderbuffer_move_to_temp sets it to
> intel_image->base.Base.Level.  But I'm guessing that may not actually be
> important...

That's the reason it's still around.  If we could figure out how to make
my i965-rb-miplevels (ad2ef18ce1ea9db1d20746ed3ef1f61a96184d83) not
regress, we'd be able to drop it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140201/5992e1ec/attachment.pgp>


More information about the mesa-dev mailing list