[Mesa-dev] Fwd: [PATCH 2/2] i965: Use the new brw_load_register_mem helper for draw indirect.

[Chris Forbes]

Forgot to cc the list.


---------- Forwarded message ----------
From: Chris Forbes <chrisf at ijw.co.nz>
Date: Fri, Feb 7, 2014 at 1:24 PM
Subject: Re: [Mesa-dev] [PATCH 2/2] i965: Use the new
brw_load_register_mem helper for draw indirect.
To: Kenneth Graunke <kenneth at whitecape.org>


> +      } else {
> +         brw_load_register_mem(brw, GEN7_3DPRIM_START_INSTANCE, bo,
> +                               I915_GEM_DOMAIN_VERTEX, 0,
> +                               prim->indirect_offset + 12);
> +         brw_load_register_mem(brw, GEN7_3DPRIM_BASE_VERTEX, bo,
> +                               I915_GEM_DOMAIN_VERTEX, 0,
> +                               prim->indirect_offset + 12);

This looks (benignly) bogus: you're writing the start instance value
here into the base vertex register, and then immediately afterward
writing an immediate zero over it.

With that fixed (or justified):

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

> +         BEGIN_BATCH(3);
>           OUT_BATCH(MI_LOAD_REGISTER_IMM | (3 - 2));
>           OUT_BATCH(GEN7_3DPRIM_BASE_VERTEX);
>           OUT_BATCH(0);
> +         ADVANCE_BATCH();
>        }
> -
> -      ADVANCE_BATCH();
>     }
>     else {
>        indirect_flag = 0;
> --
> 1.8.4.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev