[Mesa-dev] [PATCH] configure: Use LLVM shared libraries by default

Emil Velikov emil.l.velikov at gmail.com
Sat Feb 8 00:13:34 CET 2014


On 04/02/14 19:24, Tom Stellard wrote:
> From: Tom Stellard <thomas.stellard at amd.com>
> 
> Linking with LLVM static libraries is easily broken by changes to
> the llvm-config program or when LLVM adds, removes, or changes library
> components.  Keeping up with these changes requires a lot of maintanence
> effort to keep the build working on the master and stable branches.
> 
> Also, because of issues in the past LLVM static libraries, the release
> manager is currently configuring with --with-llvm-shared-libs when
> checking the build before release.  Enabling shared libraries by
> default would allow the release manager to run ./configure with
> no arguments, and be reasonably confident that the build would succeed.
> 
> CC: "10.1" <mesa-stable at lists.freedesktop.org>
> 
Currently building with with_llvm_shared_libs=no will force us to export
of llvm's symbols. Which is to put it mildly a pain in the neck.

Acked-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks
-Emil
> ---
>  configure.ac | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4da6c51..9568e7b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1528,11 +1528,11 @@ AC_ARG_ENABLE([gallium-llvm],
>      [enable_gallium_llvm="$enableval"],
>      [enable_gallium_llvm=auto])
>  
> -AC_ARG_WITH([llvm-shared-libs],
> -    [AS_HELP_STRING([--with-llvm-shared-libs],
> -        [link with LLVM shared libraries @<:@default=disabled@:>@])],
> +AC_ARG_ENABLE([llvm-shared-libs],
> +    [AS_HELP_STRING([--enable-llvm-shared-libs],
> +        [link with LLVM shared libraries @<:@default=enabled@:>@])],
>      [],
> -    [with_llvm_shared_libs=no])
> +    [with_llvm_shared_libs=yes])
>  
>  AC_ARG_WITH([llvm-prefix],
>      [AS_HELP_STRING([--with-llvm-prefix],
> 



More information about the mesa-dev mailing list