[Mesa-dev] [PATCH 16/22] targets/dri: automake: add test for exported symbols

[Emil Velikov]

On 08/02/14 19:13, Matt Turner wrote:
> On Sat, Feb 8, 2014 at 8:04 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> dri targets should export the following
>>  - __driDriverExtensions
>>  - __dri2ConfigOptions
>> and
>>  - *winsys_create > for gl-vdpau interop
>>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>  src/gallium/Automake.inc                     |  1 -
>>  src/gallium/targets/dri-i915/Makefile.am     |  5 +++++
>>  src/gallium/targets/dri-ilo/Makefile.am      |  5 +++++
>>  src/gallium/targets/dri-nouveau/Makefile.am  |  6 ++++++
>>  src/gallium/targets/dri-swrast/Makefile.am   |  5 +++++
>>  src/gallium/targets/dri-symbols-check        | 15 +++++++++++++++
>>  src/gallium/targets/dri-vmwgfx/Makefile.am   |  5 +++++
>>  src/gallium/targets/r300/dri/Makefile.am     |  6 ++++++
>>  src/gallium/targets/r600/dri/Makefile.am     |  6 ++++++
>>  src/gallium/targets/radeonsi/dri/Makefile.am |  6 ++++++
>>  10 files changed, 59 insertions(+), 1 deletion(-)
>>  create mode 100755 src/gallium/targets/dri-symbols-check
>>
>> diff --git a/src/gallium/Automake.inc b/src/gallium/Automake.inc
>> index 57ac9fd..0ba7e57 100644
>> --- a/src/gallium/Automake.inc
>> +++ b/src/gallium/Automake.inc
>> @@ -51,7 +51,6 @@ GALLIUM_VIDEO_CFLAGS = \
>>         $(VISIBILITY_CFLAGS)
>>
>>
>> -# TODO: add -export-symbols-regex
>>  GALLIUM_DRI_LINKER_FLAGS = \
>>         -module \
>>         -avoid-version \
>> diff --git a/src/gallium/targets/dri-i915/Makefile.am b/src/gallium/targets/dri-i915/Makefile.am
>> index 3f8468f..1155b8b 100644
>> --- a/src/gallium/targets/dri-i915/Makefile.am
>> +++ b/src/gallium/targets/dri-i915/Makefile.am
>> @@ -59,6 +59,11 @@ AM_CPPFLAGS += -DGALLIUM_LLVMPIPE
>>  i915_dri_la_LIBADD += $(top_builddir)/src/gallium/drivers/llvmpipe/libllvmpipe.la $(LLVM_LIBS)
>>  endif
>>
>> +AM_TESTS_ENVIRONMENT = \
>> +       export TARGET=i915;
>> +
>> +TESTS = ../dri-symbols-check
> 
> Does this work for out of tree builds?
> 
Initially I used ${top_srcdir}, but it seems like automake does not like
it wrt tests. And yes, all of the tests pass (apart from two st/xvmc
tests unrelated to this series) and are conducted on a OOT build.

-Emil