[Mesa-dev] [PATCH 13/22] st/vdpau: do not export VdpPresentationQueueTargetCreateX11

[Christian König]

Am 08.02.2014 17:03, schrieb Emil Velikov:
> The function pointer is retrieved via VdpGetProcAddress just
> like all the other vdpau functions and should not be exported.
>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>

[PATCH 13/22] st/vdpau: do not export VdpPresentationQueueTargetCreateX11
[PATCH 14/22] st/vdpau: automake: export only PUBLIC symbols
[PATCH 15/22] targets/vdpau: automake: add exported symbol tests
[PATCH 19/22] omx: use VISIBILITY_CFLAGS to control exported symbols
[PATCH 22/22] targets/omx: automake: add symbol test

Those patches are: Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   src/gallium/state_trackers/vdpau/device.c        | 2 +-
>   src/gallium/state_trackers/vdpau/vdpau_private.h | 4 +++-
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/state_trackers/vdpau/device.c b/src/gallium/state_trackers/vdpau/device.c
> index def1e2a..0cdda73 100644
> --- a/src/gallium/state_trackers/vdpau/device.c
> +++ b/src/gallium/state_trackers/vdpau/device.c
> @@ -106,7 +106,7 @@ no_htab:
>   /**
>    * Create a VdpPresentationQueueTarget for use with X11.
>    */
> -PUBLIC VdpStatus
> +VdpStatus
>   vlVdpPresentationQueueTargetCreateX11(VdpDevice device, Drawable drawable,
>                                         VdpPresentationQueueTarget *target)
>   {
> diff --git a/src/gallium/state_trackers/vdpau/vdpau_private.h b/src/gallium/state_trackers/vdpau/vdpau_private.h
> index 08afe60..2f4d651 100644
> --- a/src/gallium/state_trackers/vdpau/vdpau_private.h
> +++ b/src/gallium/state_trackers/vdpau/vdpau_private.h
> @@ -436,7 +436,6 @@ boolean vlGetFuncFTAB(VdpFuncId function_id, void **func);
>   
>   /* Public functions */
>   VdpDeviceCreateX11 vdp_imp_device_create_x11;
> -VdpPresentationQueueTargetCreateX11 vlVdpPresentationQueueTargetCreateX11;
>   
>   void vlVdpDefaultSamplerViewTemplate(struct pipe_sampler_view *templ, struct pipe_resource *res);
>   
> @@ -507,6 +506,9 @@ VdpVideoMixerGetParameterValues vlVdpVideoMixerGetParameterValues;
>   VdpVideoMixerGetAttributeValues vlVdpVideoMixerGetAttributeValues;
>   VdpVideoMixerDestroy vlVdpVideoMixerDestroy;
>   VdpGenerateCSCMatrix vlVdpGenerateCSCMatrix;
> +/* Winsys specific internal function pointers */
> +VdpPresentationQueueTargetCreateX11 vlVdpPresentationQueueTargetCreateX11;
> +
>   
>   /* interop to mesa state tracker */
>   VdpVideoSurfaceGallium vlVdpVideoSurfaceGallium;