[Mesa-dev] [PATCH 01/10] radeonsi: move PA_SU_POLY_OFFSET_DB_FMT_CNTL to framebuffer state

[Chris Forbes]

[Possibly ignore that, I guess it's the negated number of mantissa bits]

On Tue, Feb 11, 2014 at 3:39 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:
> FORMAT_X8Z24_UNORM:
>> +       case PIPE_FORMAT_Z24X8_UNORM:
>> +       case PIPE_FORMAT_Z24_UNORM_S8_UINT:
>> +               pa_su_poly_offset_db_fmt_cntl = S_028B78_POLY_OFFSET_NEG_NUM_DB_BITS(-24);
>> +               break;
>> +       case PIPE_FORMAT_Z32_FLOAT:
>> +       case PIPE_FORMAT_Z32_FLOAT_S8X24_UINT:
>> +               pa_su_poly_offset_db_fmt_cntl = S_028B78_POLY_OFFSET_NEG_NUM_DB_BITS(-23) |
>> +                                               S_028B78_POLY_OFFSET_DB_IS_FLOAT_FMT(1);
>> +               break;
>
> I don't know much about SI, but this jumped out as weird -- shouldn't
> that be -32?