[Mesa-dev] [PATCH 1/3] i965/fs: Drop dead comment about the old proj_attrib_mask optimization.

[Kenneth Graunke]

On 02/14/2014 04:48 PM, Eric Anholt wrote:
> The code was removed early last year.
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index 4f5558b..d35928e 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -1108,12 +1108,6 @@ fs_visitor::emit_general_interpolation(ir_variable *ir)
>  	 } else {
>  	    /* Smooth/noperspective interpolation case. */
>  	    for (unsigned int k = 0; k < type->vector_elements; k++) {
> -	       /* FINISHME: At some point we probably want to push
> -		* this farther by giving similar treatment to the
> -		* other potentially constant components of the
> -		* attribute, as well as making brw_vs_constval.c
> -		* handle varyings other than gl_TexCoord.
> -		*/
>                 struct brw_reg interp = interp_reg(location, k);
>                 emit_linterp(attr, fs_reg(interp), interpolation_mode,
>                              ir->data.centroid && !c->key.persample_shading,
> 

Patch 1 and 3 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

(I haven't had time to look at 3.  Don't wait for me if someone else does.)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140214/676b1e7b/attachment-0001.pgp>