[Mesa-dev] [PATCH 1/2] vl: add motion adaptive deinterlacer

[Grigori Goronzy]

On 15.02.2014 13:14, Andy Furniss wrote:
> Thanks Grigori for doing this - looks really good on HD stuff I've
> tested and of course is easily fast enough, unlike anything on the CPU
> at high res.
>
> Any plans for the future?
>

Well, adding edge-guided spatial interpolation for the temporal-spatial 
mode of VDPAU, I have preliminary shader code for this already. Also, 
motion detection isn't quite perfect, and should be improved.

> Pre-filtered bicubic HQ scaling would be nice :-)
>

Can you describe in more detail what you mean? Better quality scaling is 
possible, but that would be applied *after* deinterlacing.

> Below not specific to the deinterlacer, but I would be interested if
> others see these as my card is not UVD so I have to patch to get the
> deinterlacer to work - I know this breaks decode, but that's no problem
> for me.
>
> So I set  PIPE_VIDEO_CAP_PREFERS_INTERLACED
> PIPE_VIDEO_CAP_SUPPORTS_INTERLACED to true.
>
> I saw in the code comment that 422 isn't supported, so tested - roughly
> works but can have issues depending on source - but unsupported is not
> the issue.
>

The deinterlacer currently always renders into a 420 surface, so even if 
you get some output, the chroma won't be correct. :)

> I noticed that the weave shader also has issues with 422 - I didn't
> expect this as using the progressive (for me unpatched mesa) looks OK -
> so is 422 supposed to be supported by weave?
>
> At the start or when I press f on mplayer to toggle between full/window
> I see a frame of old/uninitialised video mem - does this happen on nvidia?
>

MPlayer can be quite flawed. Have you tried mpv?

Best regards
Grigori