[Mesa-dev] [PATCH V2] i965: Fix the region's pitch condition to use blitter

[Ian Romanick]

On 01/07/2014 05:46 PM, Anuj Phogat wrote:
> intelEmitCopyBlit uses a signed 16-bit integer to represent
> buffer pitch, so it can only handle buffer pitches < 32k.
> 
> Cc: mesa-stable at lists.freedesktop.org
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
> Dropping few changes made in earlier patch. If region->bo->size >= 
> max_gtt_map_object_size, we can't fall back to intel_miptree_map_gtt().
> 
>  src/mesa/drivers/dri/i965/intel_blit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c
> index 7bc289f..32431b9 100644
> --- a/src/mesa/drivers/dri/i965/intel_blit.c
> +++ b/src/mesa/drivers/dri/i965/intel_blit.c
> @@ -199,9 +199,9 @@ intel_miptree_blit(struct brw_context *brw,
>      * As a result of these two limitations, we can only use the blitter to do
>      * this copy when the region's pitch is less than 32k.
>      */
> -   if (src_mt->region->pitch > 32768 ||
> -       dst_mt->region->pitch > 32768) {
> -      perf_debug("Falling back due to >32k pitch\n");
> +   if (src_mt->region->pitch >= 32768 ||
> +       dst_mt->region->pitch >= 32768) {
> +      perf_debug("Falling back due to >=32k pitch\n");
>        return false;
>     }
>  
>