[Mesa-dev] [PATCH 05/38] st/dri: set the implemented version of __DRItexBufferExtension

[Ian Romanick]

On 02/18/2014 06:01 PM, Ian Romanick wrote:
> On 02/12/2014 05:17 PM, Emil Velikov wrote:
>> ... over the version number provided by the headers.
>>
>> Explicitly set extension members to improve clarity.
>>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> 
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> 
> But you might also wait for an R-b from someone that works on that code.

In particular, I think people compile this code with MSVC, and I don't
think it supports designated initializers.

>> ---
>>  src/gallium/state_trackers/dri/common/dri_drawable.c | 9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/gallium/state_trackers/dri/common/dri_drawable.c b/src/gallium/state_trackers/dri/common/dri_drawable.c
>> index a399938..074321d 100644
>> --- a/src/gallium/state_trackers/dri/common/dri_drawable.c
>> +++ b/src/gallium/state_trackers/dri/common/dri_drawable.c
>> @@ -258,10 +258,11 @@ dri_set_tex_buffer(__DRIcontext *pDRICtx, GLint target,
>>  }
>>  
>>  const __DRItexBufferExtension driTexBufferExtension = {
>> -    { __DRI_TEX_BUFFER, __DRI_TEX_BUFFER_VERSION },
>> -   dri_set_tex_buffer,
>> -   dri_set_tex_buffer2,
>> -   NULL,
>> +   .base = { __DRI_TEX_BUFFER, 2 },
>> +
>> +   .setTexBuffer       = dri_set_tex_buffer,
>> +   .setTexBuffer2      = dri_set_tex_buffer2,
>> +   .releaseTexBuffer   = NULL,
>>  };
>>  
>>  /**
>>
>