[Mesa-dev] [PATCH 00/19] i965/fs clean ups

Matt Turner mattst88 at gmail.com
Thu Feb 20 13:41:13 PST 2014


Matt Turner (19):
  i965: Reduce predicate field of backend_instruction to uint8_t.
  i965: Mark brw_reg_type and register_file enums as PACKED.
  i965/fs: Reduce the sizes of some fs_reg members.
  i965/fs: Make fs_reg's type an enum for better debugging.
  i965/fs: Reorder fs_reg for better packing.
  i965/fs: Reduce the sizes of some fs_inst members.
  i965/fs: Reorder fs_inst's fields for better packing.
  i965/fs: Use a bitfield for fs_inst's bool fields.

These shrink the backend_instruction, fs_reg, and fs_inst classes by
using appropriately sized types and reordering the fields for better
packing.

  i965/fs: Use reg_undef instead of unset fs_reg constructor.
  i965/fs: Drop redundant zero assignments in fs_inst::init().
  i965/fs: Move setting opcode = NOP to its one useful location.
  i965/fs: Pass fs_regs by constant reference where possible.
  i965/fs: Make fs_visitor::emit take a constant reference to an
    fs_inst.

Some clean ups, and changes to pass fs_regs and fs_inst by reference.

  i965/fs: Add and use an fs_inst copy constructor.
  i965/fs: Disable fs_inst assignment operator.
  i965/fs: Combine fs_inst constructors using default parameters.
  i965/fs: ralloc fs_inst's fs_reg sources.
  i965/fs: Store the number of sources an fs_inst has.
  i965/fs: Add a function to resize fs_inst's sources array.

Change's fs_inst's 3-element fs_reg src array to be a pointer that
can be reallocated if necessary. No functional change, as three
sources are always allocated. The last three patches will wait
for users before being committed.

 src/mesa/drivers/dri/i965/brw_fs.cpp         | 125 +++++++++++++--------------
 src/mesa/drivers/dri/i965/brw_fs.h           | 120 +++++++++++++------------
 src/mesa/drivers/dri/i965/brw_fs_fp.cpp      |   4 +-
 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp |  23 ++---
 src/mesa/drivers/dri/i965/brw_reg.h          |   3 +-
 src/mesa/drivers/dri/i965/brw_shader.cpp     |   2 +-
 src/mesa/drivers/dri/i965/brw_shader.h       |   8 +-
 7 files changed, 149 insertions(+), 136 deletions(-)

-- 
1.8.3.2



More information about the mesa-dev mailing list