[Mesa-dev] [PATCH] mesa: Remove unnecessary condition

Courtney Goeltzenleuchter courtney at lunarg.com
Fri Feb 21 09:31:43 PST 2014


Identified by Valgrind memory check. Initialized block-opaque
in a different patch.
This test seems unnecessary.
If opaque must be true, just set to true.
Signed-off-by: Courtney Goeltzenleuchter <courtney at LunarG.com>
---
 src/mesa/main/texcompress_etc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mesa/main/texcompress_etc.c b/src/mesa/main/texcompress_etc.c
index 97adc86..e22f2fc 100644
--- a/src/mesa/main/texcompress_etc.c
+++ b/src/mesa/main/texcompress_etc.c
@@ -430,8 +430,7 @@ etc2_rgb8_parse_block(struct etc2_block *block,
       block->is_planar_mode = true;
 
       /* opaque bit must be set in planar mode */
-      if (!block->opaque)
-         block->opaque = true;
+      block->opaque = true;
 
       for (i = 0; i < 3; i++) {
          block->base_colors[0][i] = etc2_base_color_o_planar(src, i);
-- 
1.8.3.2



More information about the mesa-dev mailing list