[Mesa-dev] [PATCH 08/19] i965/fs: Use a bitfield for fs_inst's bool fields.

[Kenneth Graunke]

On 02/20/2014 01:41 PM, Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_fs.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h
> index b4e69ba..a1f33e7 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.h
> +++ b/src/mesa/drivers/dri/i965/brw_fs.h
> @@ -203,7 +203,6 @@ public:
>     uint32_t texture_offset; /**< Texture offset bitfield */
>     uint32_t offset; /* spill/unspill offset */
>  
> -   bool saturate;
>     uint8_t conditional_mod; /**< BRW_CONDITIONAL_* */
>  
>     /* Chooses which flag subregister (f0.0 or f0.1) is used for conditional
> @@ -216,12 +215,13 @@ public:
>     int8_t base_mrf; /**< First MRF in the SEND message, if mlen is nonzero. */
>     uint8_t sampler;
>     uint8_t target; /**< MRT target. */
> -   bool eot;
> -   bool header_present;
> -   bool shadow_compare;
> -   bool force_uncompressed;
> -   bool force_sechalf;
> -   bool force_writemask_all;
> +   uint8_t saturate:1;
> +   uint8_t eot:1;
> +   uint8_t header_present:1;
> +   uint8_t shadow_compare:1;
> +   uint8_t force_uncompressed:1;
> +   uint8_t force_sechalf:1;
> +   uint8_t force_writemask_all:1;
>  };

And now, for the amazing 8-bit, 1-bit values!  Hurg.

Please just do:

   unsigned eot:1;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140221/143f02e6/attachment.pgp>