[Mesa-dev] [PATCH] i965/fs: Make fs_reg's type an enum for better debugging.

Kenneth Graunke kenneth at whitecape.org
Fri Feb 21 14:31:09 PST 2014


From: Matt Turner <mattst88 at gmail.com>

Since the enum is marked as packed, it'll still take only one byte.
---
 src/mesa/drivers/dri/i965/brw_fs.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

This is a proposed replacement for Matt's patch 13/19, and also obsoletes
part of patch 14/19.

diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h
index 5bc43c3..07296ff 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.h
+++ b/src/mesa/drivers/dri/i965/brw_fs.h
@@ -74,7 +74,7 @@ public:
    fs_reg(uint32_t u);
    fs_reg(struct brw_reg fixed_hw_reg);
    fs_reg(enum register_file file, int reg);
-   fs_reg(enum register_file file, int reg, uint32_t type);
+   fs_reg(enum register_file file, int reg, enum brw_reg_type type);
    fs_reg(class fs_visitor *v, const struct glsl_type *type);
 
    bool equals(const fs_reg &r) const;
@@ -83,7 +83,7 @@ public:
    bool is_null() const;
    bool is_valid_3src() const;
    bool is_contiguous() const;
-
+   fs_reg retype(enum brw_reg_type type);
    fs_reg &apply_stride(unsigned stride);
 
    /** Register file: GRF, MRF, IMM. */
@@ -102,7 +102,7 @@ public:
     */
    int reg_offset;
    /** Register type.  BRW_REGISTER_TYPE_* */
-   uint8_t type;
+   enum brw_reg_type type;
    bool negate;
    bool abs;
    struct brw_reg fixed_hw_reg;
-- 
1.9.0



More information about the mesa-dev mailing list