[Mesa-dev] [PATCH 05/19] i965/fs: Reorder fs_reg for better packing.

Kenneth Graunke kenneth at whitecape.org
Fri Feb 21 14:36:31 PST 2014


On 02/20/2014 01:41 PM, Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_fs.h | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)

Depending whether you decide to keep packing enums or not, you may want
to reorder this.

Patches 1, 3-7, 8 with the bool:1 change, 9, 11-12 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I don't see a lot of utility in the last few patches (15-19) without
your later patches to actually use more than 3 sources.  We could take
them now so you don't have to carry them, or wait a bit...I'm kind of
ambivalent.

--Ken

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140221/47a0bc78/attachment.pgp>


More information about the mesa-dev mailing list