[Mesa-dev] [PATCH 0/3] dri3: Add GLX_EXT_buffer_age support

Adel Gadllah adel.gadllah at gmail.com
Fri Feb 21 17:12:15 PST 2014


Am 21.02.2014 23:47, schrieb Ian Romanick:
> On 02/20/2014 02:15 AM, Adel Gadllah wrote:
>> Hi,
>>
>> OK here are updated patches based on the review comments. The first one simply
>> updates the glxext.h header even though that turned out to not be required
>> for this but it doesn't hurt doing it anyway.
>>
>> The second one refactors glx_pbuffer based on the review comments
>> from Ian (assuming I got what he meant).
>>
>> Finally the third patch adds glx_ext_buffer_age support to dri3.
>
> Series is
>
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>
> Patches 1 & 2 should be able to land right away.
>
> For the implementation of GLX_EXT_buffer_age... do we have any test cases?

No I have been testing it with clutter applications specifically gnome-shell.

> Does Robert perhaps have something around that we could put in piglit?  We don't generaly land new features without 
> any tests.  I would have mentioned this before, but I didn't notice that there weren't any tests.
>
I don't know. Do we have any test case for the EGL one?
> It shouldn't be too hard to make some rendering tests that clear the window to a different color each frame.  After 
> calling SwapBuffers, query the age and check that the color matches the expected value.
>
I have put something together that does that (sent as separate patch).

Adel


More information about the mesa-dev mailing list