[Mesa-dev] [PATCH 15/19] i965/fs: Disable fs_inst assignment operator.

[Pohjolainen, Topi]

On Thu, Feb 20, 2014 at 01:41:28PM -0800, Matt Turner wrote:
> The fs_reg src array is going to turn into a pointer and we'd rather not
> consider the implications of shallow copying fs_insts.
> ---
>  src/mesa/drivers/dri/i965/brw_fs.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h
> index 054008e..77df64b 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.h
> +++ b/src/mesa/drivers/dri/i965/brw_fs.h
> @@ -168,6 +168,8 @@ public:
>  };
>  
>  class fs_inst : public backend_instruction {
> +   fs_inst &operator=(const fs_inst &);

Nit-pick, text books often use constant return:

const fs_inst &operator=(const fs_inst &);

But I think it does the trick even without:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

> +
>  public:
>     DECLARE_RALLOC_CXX_OPERATORS(fs_inst)
>  
> -- 
> 1.8.3.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev