[Mesa-dev] [PATCH 19/25] gallium/i915: handle query_renderer caps

[Stéphane Marchesin]

On Sat, Feb 22, 2014 at 5:22 AM, Emil Velikov <emil.l.velikov at gmail.com>wrote:

> On 22/02/14 03:33, Stéphane Marchesin wrote:
> > On Fri, Feb 21, 2014 at 7:04 PM, Emil Velikov <emil.l.velikov at gmail.com
> >wrote:
> >
> >> Implementation is a verbatim copy from the classic driver.
> >>
> >> This introduces a driver dependency on libdrm-intel, as the winsys does
> not
> >> cache the aperture size of the device.
> >>
> >
> > Usually if you have to add calls into libdrm, you add them to the winsys,
> > and then add a new entry point to the winsys which you call... If you
> want
> > I can do it.
> >
> > I've been ensuring that the only place calling into libdrm was the winsys
> > so far. Whether or not we remove the sw winsys, I think it's a healthy
> > thing to do.
> >
> Agreed, keeping OS/platform specifics within the winsys is the way to do
> it.
>
> Should I store the device aperture size within i915_winsys or is there a
> more suitable place for it ? The current implementation is essentially a
> vtable for the drm/sw callbacks.
>

I would probably just add a function to the winsys to get the aperture
size. Basically copy-paste that big chunk of code from case
PIPE_CAP_VIDEO_MEMORY into int iws->aperture_size(struct i915_winsys *iws);

Stéphane
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140223/f42cc43e/attachment.html>