[Mesa-dev] [PATCH 1/2] R600/SI: Allow SI_KILL for geometry shaders

[Michel Dänzer]

On Mon, 2014-02-24 at 10:06 -0800, Tom Stellard wrote:
> On Mon, Feb 24, 2014 at 06:02:23PM +0900, Michel Dänzer wrote:
> > 
> > diff --git a/test/CodeGen/R600/llvm.AMDGPU.kill.ll b/test/CodeGen/R600/llvm.AMDGPU.kill.ll
> > new file mode 100644
> > index 0000000..0abe694
> > --- /dev/null
> > +++ b/test/CodeGen/R600/llvm.AMDGPU.kill.ll
> > @@ -0,0 +1,18 @@
> > +; RUN: llc < %s -march=r600 -mcpu=verde -verify-machineinstrs | FileCheck --check-prefix=SI-CHECK %s
> > +
> > +; SI-LABEL: @kill_gs
> 
> Since your prefix is SI-CHECK, this would need to be SI-CHECK-LABEL.

Ah, I think I'll prefer just SI as the prefix instead. :)


> With that fix,
> Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

Thanks. Is that just for this patch, or all three of them?


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer