[Mesa-dev] [PATCH 09/25] dri/radeon: create radeon{Vendor, GetRenderer}String helpers

[Marek Olšák]

Oh, I get it now. Sorry for the noise.

Marek

On Tue, Feb 25, 2014 at 1:27 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 24/02/14 20:06, Marek Olšák wrote:
>> On Sat, Feb 22, 2014 at 4:03 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> To be used by the upcomming GLX_MESA_query_renderer implementation.
>>>
>>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>>> ---
>>>  .../drivers/dri/radeon/radeon_common_context.c     | 50 +++++++++++++---------
>>>  .../drivers/dri/radeon/radeon_common_context.h     |  4 ++
>>>  src/mesa/drivers/dri/radeon/radeon_screen.h        |  2 +
>>>  3 files changed, 35 insertions(+), 21 deletions(-)
>>>
>> [snip]
>>> diff --git a/src/mesa/drivers/dri/radeon/radeon_screen.h b/src/mesa/drivers/dri/radeon/radeon_screen.h
>>> index 03abb2a..39341c8 100644
>>> --- a/src/mesa/drivers/dri/radeon/radeon_screen.h
>>> +++ b/src/mesa/drivers/dri/radeon/radeon_screen.h
>>> @@ -211,6 +211,8 @@ struct __DRIimageRec {
>>>  #define untile_image                        r200_untile_image
>>>  #define set_re_cntl_d3d                     r200_set_re_cntl_d3d
>>>  #define radeonDestroyBuffer                 r200_radeonDestroyBuffer
>>> +#define radeonVendorString                  r200_radeonVendorString
>>> +#define radeonGetRendererString             r200_radeonGetRendererString
>>>  #endif
>>
>> Where are these r200 functions implemented?
>>
>> Marek
>>
>
> It's a different kettle of fish I'm afraid.
>
> radeonVendorString and radeonGetRendererString are the generic
> implementation in dri/radeon. As classic drivers build into a single
> megadriver one needs to redefine them when building r200 to prevent
> duplicating symbols.
>
> If that sounds a bit off the following command will quickly share some
> light on what I'm talking about (note #define untile_image
> r200_untile_image)
>
>  $ git grep untile_image -- src/mesa/drivers/dri/r*
>
>
> Cheers
> -Emil