[Mesa-dev] [PATCH] gbm: export gbm_device_is_format_supported

Emil Velikov emil.l.velikov at gmail.com
Thu Feb 27 06:51:18 PST 2014


On 27/02/14 08:23, Marek Chalupa wrote:
> Probably depending on compiler settings, the definition can be hidden,
> so undefined reference error can be encountred during linking
> 
When building with automake, the definition will be hidden if the
compiler supports visibility flags. This was done with an earlier patch
that adds them for the gbm target. The patch is only present in master
so the stable branches are safe on that regard.

This symbol fell short when I was going through the gbm api, thanks for
catching that.

Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

> https://bugs.freedesktop.org/show_bug.cgi?id=75528
> ---
>  src/gbm/main/gbm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c
> index 7a4e406..b057386 100644
> --- a/src/gbm/main/gbm.c
> +++ b/src/gbm/main/gbm.c
> @@ -81,7 +81,7 @@ gbm_device_get_backend_name(struct gbm_device *gbm)
>   *
>   * \sa enum gbm_bo_format for the list of formats
>   */
> -int
> +GBM_EXPORT int
>  gbm_device_is_format_supported(struct gbm_device *gbm,
>                                 uint32_t format, uint32_t usage)
>  {
> 



More information about the mesa-dev mailing list