[Mesa-dev] [PATCH 1/3] r300g/tests: Added missing fclose for FILE resource.

Ian Romanick idr at freedesktop.org
Fri Feb 28 14:54:43 PST 2014


On 02/28/2014 12:32 PM, Kristian Høgsberg wrote:
> On Mon, Feb 10, 2014 at 01:28:14PM +0330, Siavash Eliasi wrote:
>
> Oops, we almost lost these three fixes.  Reviewed and pushed all three.

Sould any / all of these be on the 10.1 list?

> Kristian
>
>> ---
>>   src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c b/src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c
>> index b4e30d8..239a762 100644
>> --- a/src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c
>> +++ b/src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c
>> @@ -557,6 +557,7 @@ unsigned load_program(
>>   		if (last_char && last_char != '\n') {
>>   			fprintf(stderr, "Error line cannot be longer than 100 "
>>   				"characters:\n%s\n", line);
>> +			fclose(file);
>>   			return 0;
>>   		}
>>
>> @@ -605,5 +606,7 @@ unsigned load_program(
>>   		// XXX: Parse immediates from the file.
>>   		add_instruction(c, test->input[i]);
>>   	}
>> +
>> +	fclose(file);
>>   	return 1;
>>   }
>> --
>> 1.8.5.4
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>



More information about the mesa-dev mailing list