[Mesa-dev] [PATCH 0/4] More Valgrind Fixes

Aaron Watry awatry at gmail.com
Thu Jan 2 10:38:02 PST 2014


Further valgrind memory leak fixes.

With this series applied, my evergreen (CEDAR) shows 0 bytes of
directly/indirectly/possibly lost memory, and everything that's
still in use at glxgears exit is marked as 'possibly reachable'.

The command used to test is:
valgrind --leak-check=full --show-reachable=yes glxgears

Then let it run for 5-10 seconds and then pressing exit to quit out cleanly

Results
LEAK SUMMARY:
   definitely lost: 0 bytes in 0 blocks
   indirectly lost: 0 bytes in 0 blocks
     possibly lost: 0 bytes in 0 blocks
   still reachable: 70,228 bytes in 651 blocks
        suppressed: 0 bytes in 0 blocks


I've marked 3 of the 4 patches as CC to stable, but I can't do more than
compile test the r200 patch.  If someone can, that'd be appreciated.

I've run through piglit's quick tests without any regressions on CEDAR,
and I've tested the radeonsi patch on another machine.

Aaron Watry (4):
  radeonsi: Free gfx command stream when destroying context
  st/dri: prevent leak of dri option default values
  r200: Free glCtx in radeonDestroyContext
  mesa/main: Free ctx->DrawIndirectBuffer during teardown

 src/gallium/drivers/radeonsi/radeonsi_pipe.c        | 2 ++
 src/gallium/state_trackers/dri/common/dri_screen.c  | 4 ++++
 src/mesa/drivers/dri/radeon/radeon_common_context.c | 4 ++--
 src/mesa/main/bufferobj.c                           | 2 ++
 4 files changed, 10 insertions(+), 2 deletions(-)




More information about the mesa-dev mailing list