[Mesa-dev] [PATCH 2/4] radeon: Add bo statistics dumping support

[Lauri Kasanen]

On Fri, 3 Jan 2014 17:37:15 +0100
Erik Faye-Lund <kusmabite at gmail.com> wrote:

> On Fri, Jan 3, 2014 at 4:49 PM, Lauri Kasanen <cand at gmx.com> wrote:
> > +                       fprintf(rscreen->ws->bo_stats_file, "Started at %llu\n",
> > +                               stats_time_get(ws));
> 
> Another nit: the other stats seems to use "@%llu" instead of "at %llu".

Will change.

> But looking a bit more about this, since all code-sites for
> stat_time_get() seems to be variations of:
> 
> if (ws->bo_stats_file) {
>         fprintf(..., stats_time_get(ws));
> }
> 
> ...perhaps stats_time_get is a too low-level abstraction? I'm not
> saying it is, just asking :)

It's also used in patch 3 in multiple places.

- Lauri