[Mesa-dev] [PATCH] mesa: Use get_local_param_pointer in glProgramLocalParameters4fvEXT().

Laurent Carlier lordheavym at gmail.com
Mon Jan 6 00:58:55 PST 2014


Le dimanche 5 janvier 2014, 20:10:17 Kenneth Graunke a écrit :
> Using the get_local_param_pointer helper ensures that the LocalParams
> arrays have actually been allocated before attempting to use them.
> 
> glProgramLocalParameters4fvEXT needs to do a bit of extra checking,
> but it can be simplified since the helper has already validated the
> target.
> 
> Fixes crashes in programs that use Cg (such as Awesomenauts) since
> commit e5885c119de1e508099cc1111e1c9f8ff00fab88 (mesa: Dynamically
> allocate the storage for program local parameters.).
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73136
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Cc: Eric Anholt <eric at anholt.net>

This fixes al least "Tiny and Big: Granpa's Leftover" and "Rocketbirds: 
Hardboiled Chicken" games here.

-- 
Laurent Carlier
ArchLinux Developer
http://www.archlinux.org


More information about the mesa-dev mailing list