[Mesa-dev] [v2] Cleaning compute_memory_pool from gallium/drivers/r600

Brian Paul brianp at vmware.com
Mon Jan 6 09:18:26 PST 2014


On 01/06/2014 08:15 AM, Bruno Jiménez wrote:
> Hi,
>
> This is the second version of my previous patches.
> I have cleaned a bit compute_memory_pool.c, added some
> NULL checks to the code, corrected a typo and removed
> an unneeded decraration of a function.
>
> Patches 1 and 2 are the same.
> Patch 3 changes Returns to @returns so doxygen can
>      parse it correctly.
> Patch 4 is a correction of my anterior patch, as
>      it changed the behaviour of the code. It
>      also contain an explanation of the change
> Patch 5 now, apart from removing the declaration
>      compute_memory_defrag, also removes some
>      comments that are already in
>      compute_memory_pool.c
>
> [PATCH 1/5] Fixing a typo and some indentation
> [PATCH 2/5] Adding checks for NULL after CALLOC
> [PATCH 3/5] Add more NULL checks
> [PATCH 4/5] Tidy a bit compute_memory_finalize_pending
> [PATCH 5/5] Cleanup of compute_memory_pool.h

All the git commit messages should be prefixed with "r600g".

In patch 2&3, put a space between 'if' and '('

In patch 5, the commit message could be re-wrapped to 70 columns or so.

-Brian



More information about the mesa-dev mailing list