[Mesa-dev] [PATCH 3/3] i915: Silence warning: unused parameter warning in intel_bufferobj_buffer

Ian Romanick idr at freedesktop.org
Mon Jan 6 11:14:35 PST 2014


On 01/06/2014 10:51 AM, Kenneth Graunke wrote:
> On 01/03/2014 04:51 PM, Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> intel_buffer_objects.c: In function 'old_intel_bufferobj_buffer':
> 
> "old_"? :)

There are #defines that wrap the names in i915 that are duplicates of
names in i965 (for megadrivers).

>> intel_buffer_objects.c:471:17: warning: unused parameter 'flag' [-Wunused-parameter]
>>
>> The parameter hasn't been used since the i915 and i965 drivers had their
>> breakup.  i965 got the flags, and i915 got to cry itself to sleep.
>>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> 
> Don't worry, we threw them out in i965 too.
> 
> Patch 3 is:
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list