[Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

Brian Paul brianp at vmware.com
Mon Jan 6 12:36:33 PST 2014


On 01/06/2014 01:21 PM, Chris Forbes wrote:
> +         const GLboolean signd =
> +            rb ? _mesa_is_format_signed(rb->
> Format) : GL_FALSE;
> +         v->value_int_4[0] =
> +         v->value_int_4[1] =
> +         v->value_int_4[2] =
> +         v->value_int_4[3] = signd;
>
> Might have gone with something like is_signed rather than dropping a
> letter to avoid the keyword.

Done.  I like that better too.


> Either way,
>
> Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

Thanks.

-Brian



More information about the mesa-dev mailing list