[Mesa-dev] [v3][r600g] Cleaning compute_memory_pool from gallium/drivers/r600

Marek Olšák maraeo at gmail.com
Mon Jan 6 15:12:27 PST 2014


The r600g prefix is wrong. Your commit messages should follow the same
conventions the other Mesa developers use (see the git log for examples).

Since you're changing compute, you should use the prefix
"r600g/compute:" ("r600g:" is okay too), but never "[r600g]". The
subjects of your emails don't have any prefix, which is wrong too and
it's why I ignored your emails until now.

Marek

On Mon, Jan 6, 2014 at 10:47 PM, Bruno Jiménez <brunojimen at gmail.com> wrote:
> Hi,
>
> Third version of the patches.
>
> Now with r600g in the commit messages.
> Patches 2 and 3 have spaces between 'if' and '('.
> Patches 1,4 and 5 are the same.
>
> Thanks!
>
> [PATCH 1/5] [r600g] Fixing a typo and some indentation
> [PATCH 2/5] [r600g] Adding checks for NULL after CALLOC
> [PATCH 3/5] [r600g] Add more NULL checks
> [PATCH 4/5] [r600g] Tidy a bit compute_memory_finalize_pending
> [PATCH 5/5] [r600g] Cleanup of compute_memory_pool.h
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list