[Mesa-dev] [PATCH 2/4] radeon: Add bo statistics dumping support

Lauri Kasanen cand at gmx.com
Tue Jan 7 01:44:21 PST 2014


On Tue, 7 Jan 2014 00:22:08 +0100
Marek Olšák <maraeo at gmail.com> wrote:

> Is the logging really needed apart from initial debugging and
> validation of the code? I don't see a reason to have this in master.

Yes, it's there to allow users to submit traces, which then means much
better coverage (private apps, commercial apps...).

> Also, pipe_screen functions must not change the contents of
> radeon_winsys. They are different objects. The two can only
> communicate using the functions declared in the radeon_winsys
> structure.

OK, will add winsys functions instead.

- Lauri


More information about the mesa-dev mailing list