[Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

Matt Turner mattst88 at gmail.com
Tue Jan 7 14:21:07 PST 2014


On Tue, Jan 7, 2014 at 2:05 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 01/07/2014 12:31 PM, Thomas Sondergaard wrote:
>> This small rearrangement avoids MSVC 2013 ICE. Also, this should be a better
>> memory access order.
>
> Can you explain this better?  As far as I can tell, this just changes
> the order the indices are visited (and has a spurious, incorrect
> whitespace change).  This shouldn't affect the correctness of the code
> at all.

I can't which thing you're asking about (the ICE, or the memory access
pattern), but the memory access pattern claim seems correct. He's
reversing the loops, so that consecutive iterations of the inner loop
operate on contiguous memory.

The correctness of the code doesn't ever seem to have been in question.


More information about the mesa-dev mailing list