[Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

[Lauri Kasanen]

On Wed, 8 Jan 2014 12:03:12 +0100
Marek Olšák <maraeo at gmail.com> wrote:

> On Tue, Jan 7, 2014 at 7:14 PM, Lauri Kasanen <cand at gmx.com> wrote:
> > These will be used later on for optimizing the VRAM placement.
> >
> > No measurable overhead (glxgears, torcs).
> >
> > v2: Get accurate stats by taking dirty_masks into account
> 
> Why don't you just set the statistics once per CS in
> radeon_drm_cs_flush? I don't see a value in doing it in every function
> that sets the resources.

It's the only way to get accurate statistics that I can see. Doing it
per-cs could be off by big amounts (100x even?). Being off by that much
could lead to rather worse decisions.

Also, as there isn't any measurable overhead, the only downside I can
see is having the code there.

> Also, last_cpu_time will be wrong anyway, because the driver may call
> the buffer_map function only once per buffer, e.g. at buffer creation.
> It's not a rule, but it happens.

I'll investigate this, thanks.

- Lauri