[Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

[Thomas Sondergaard]

On 08-01-2014 00:11, Brian Paul wrote:
> On 01/07/2014 03:30 PM, Ian Romanick wrote:
>> On 01/07/2014 02:22 PM, Thomas Sondergaard wrote:
>>> On 2014-01-07 23:05, Ian Romanick wrote:
>>>> On 01/07/2014 12:31 PM, Thomas Sondergaard wrote:
>>>>> This small rearrangement avoids MSVC 2013 ICE. Also, this should be a
>>>>> better
>>>>> memory access order.
>>>>
>>>> Can you explain this better?  As far as I can tell, this just changes
>>>> the order the indices are visited (and has a spurious, incorrect
>>>> whitespace change).  This shouldn't affect the correctness of the code
>>>> at all.
>>>
>>> No, the error is in the MSVC 2013 c++ compiler which dies with an
>>> internal compiler error (ICE). It is not intended to affect the
>>> correctness of the code. I will also report the ICE to microsoft.
>>
>> Excellent.  Hurray for finding compiler bugs. :)
>>
>> With the extra whitespace change removed,
>>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>
> I already fixed the whitespace change here.
>
> I'll hold off on pushing the series in light of the other comments.
>
> -Brian

What other comments specifically. The one about fma()?