[Mesa-dev] [PATCH 7/7] c11: Make TIME_UTC a conditional macro.

Chad Versace chad.versace at linux.intel.com
Fri Jan 10 10:02:07 PST 2014


On Thu, Jan 09, 2014 at 11:32:10AM -0800, Jose Fonseca wrote:
> This series is pretty much what I proposed several months ago, rebased on top of master, with minor if any tweaks.
> 
> Still to do is remove the deprecated abstractions (which now are mere
> wrappers of the c11 ones).
> 
> That said, this series is already useful as is, not only because of
> the code de-duplication, but also because the Windows conditional var
> implemention in master is poll-based so performs quite badly, in
> particular llvmpipe with many threads.  Which is fixed here.
> 
> IMHO the rest can be done as time permits...
> 
> Jose

This series looks good to me. But I'd like to see patch 7 squashed into
patch 2 to prevent possible build failures during bisects.

I like how this series opens up opportunities for additional cleanups.
In particular, we can now begin to remove the threading wrappers in
src/egl/main.

I'm not familiar with C11's thread headers, so patch 2 is
Acked-by: Chad Versace <chad.versace at linux.intel.com>

Patches 3-7 are:
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


More information about the mesa-dev mailing list