[Mesa-dev] [PATCH 1/2] loader: refactor duplicated code into loader util lib

[Chad Versace]

On Fri, Jan 10, 2014 at 08:14:19AM -0500, Rob Clark wrote:
> On Thu, Jan 9, 2014 at 10:36 PM, Eric Anholt <eric at anholt.net> wrote:
> > Rob Clark <robdclark at gmail.com> writes:
> >
> >> From: Rob Clark <robclark at freedesktop.org>
> >>  static int
> >>  droid_open_device(void)
> >>  {
> >> @@ -773,7 +672,7 @@ dri2_initialize_android(_EGLDriver *drv, _EGLDisplay *dpy)
> >>        goto cleanup_display;
> >>     }
> >
> > forgot loader_set_logger here.  Do we want to just move that to
> > egl_dri2.c instead of each platform_*?
> 
> fwiw, default logger (if you don't call loader_set_logger()) is just
> printf.  So in theory the ones that don't call loader_set_logger()
> either had no logging before or were just using printf.  Hmm.. but
> that probably shouldn't be the case for the 'droid loader, so maybe I
> screwed that up.

FYI, in Android, the logging system uses the Android logging library,
which emits its output to a shared system log.  If you log anything with
printf in Android, it does to /dev/null.

So, the Android loader is likely broken now, but I don't have the
resources to test it either.

+Adria and Juha, who work on Android and may want to check this series.

> (disclaimer: the android loader in particular, I have no idea how to
> build/test.. so this one probably is the most likely one that I would
> have screwed up :-P)