[Mesa-dev] [PATCH 2/2] i965: Bump BRW_MAX_TEX_UNIT to 32.

[Chris Forbes]

Does this actually work for >16?

Sampler messages' descriptor only has 4 bits for the sampler index, so
it seems you'd silently lose the top bit and get the wrong sampler
parameters.

On Thu, Jan 16, 2014 at 8:08 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> This causes us to advertise:
> - GL_MAX_TEXTURE_IMAGE_UNITS = 32
> - GL_MAX_VERTEX_TEXTURE_IMAGE_UNITS = 32
> - GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS = 96
> instead of the old values of 16, 16, and 48.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_context.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> This is covered by Piglit's existing max-samplers test. (Thanks Marek!)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h
> index 63dd4a0..5908659 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.h
> +++ b/src/mesa/drivers/dri/i965/brw_context.h
> @@ -650,7 +650,7 @@ struct brw_gs_prog_data
>  };
>
>  /** Number of texture sampler units */
> -#define BRW_MAX_TEX_UNIT 16
> +#define BRW_MAX_TEX_UNIT 32
>
>  /** Max number of render targets in a shader */
>  #define BRW_MAX_DRAW_BUFFERS 8
> --
> 1.8.5.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev