[Mesa-dev] [PATCHv2] i965: Avoid extraneous fast depth clears

[Chad Versace]

On Fri, Jan 03, 2014 at 02:28:45PM +0800, Chia-I Wu wrote:
> When the depth buffer is already cleared, skip GEN6_HIZ_OP_DEPTH_CLEAR.  This
> is made possible by tracking which slices have been cleared in
> "struct intel_mipmap_level".  The hiz_cleared flag is unset when the depth
> buffer is rendered to or when a HiZ resolve is needed.
> 
> For Unigine Tropics, the FPS improvement is 1.32134% +/- 0.161878% (n=13).
> 
> v2:
> - unset hiz_cleared automatically in intel_miptree_slice_set_needs_hiz_resolve
> - set/unset hiz_cleared with intel_renderbuffer_att_set_needs_depth_resolve
> 
> Signed-off-by: Chia-I Wu <olv at lunarg.com>
> ---
>  src/mesa/drivers/dri/i965/brw_clear.c         | 54 +++++++++++++++++++--------
>  src/mesa/drivers/dri/i965/brw_draw.c          |  2 +-
>  src/mesa/drivers/dri/i965/intel_fbo.c         | 18 ++++++++-
>  src/mesa/drivers/dri/i965/intel_fbo.h         |  4 +-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 39 +++++++++++++++++++
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 21 +++++++++++
>  6 files changed, 118 insertions(+), 20 deletions(-)

This patch looks good to me.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

By the way, the patch no longer cleanly applies to master, but the
conflicts look trivial.