[Mesa-dev] [V3 PATCH 2/8] mesa: Change 4 color component ubyte formats

[Brian Paul]

On 01/17/2014 03:45 AM, Mark Mueller wrote:
> Change all 4 color component unsigned byte formats to meet spec:
>   s/MESA_FORMAT_RGBA8888\b/MESA_FORMAT_ABGR_UNORM8/g
>   s/MESA_FORMAT_RGBA8888_REV\b/MESA_FORMAT_RGBA_UNORM8/g
>   s/MESA_FORMAT_ARGB8888\b/MESA_FORMAT_BGRA_UNORM8/g
>   s/MESA_FORMAT_ARGB8888_REV\b/MESA_FORMAT_ARGB_UNORM8/g
>   s/MESA_FORMAT_RGBX8888\b/MESA_FORMAT_XBGR_UNORM8/g
>   s/MESA_FORMAT_RGBX8888_REV\b/MESA_FORMAT_RGBX_UNORM8/g
>   s/MESA_FORMAT_XRGB8888\b/MESA_FORMAT_BGRX_UNORM8/g
>   s/MESA_FORMAT_XRGB8888_REV\b/MESA_FORMAT_XRGB_UNORM8/g
>


I'm not sure this is right.  If you look at the existing code such as 
src/mesa/main/format_{un}pack.c you'll see that these formats are 
treated as packed formats, not arrays.

Changing these formats from packed to array would cause even more 
big/little-endian grief, right?

Same comment on some of the other patches.

-Brian