[Mesa-dev] [PATCH] i965: Remove redundant check in blitter-based glBlitFramebuffer().

[Kenneth Graunke]

On 01/18/2014 10:30 AM, Eric Anholt wrote:
> The intel_miptree_blit() code checks the format for us now, plus it
> handles xrgb vs argb for us.
> ---
>  src/mesa/drivers/dri/i965/intel_fbo.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c
> index f094718..7323781 100644
> --- a/src/mesa/drivers/dri/i965/intel_fbo.c
> +++ b/src/mesa/drivers/dri/i965/intel_fbo.c
> @@ -739,16 +739,6 @@ intel_blit_framebuffer_with_blitter(struct gl_context *ctx,
>              return mask;
>           }
>  
> -         gl_format src_format = _mesa_get_srgb_format_linear(src_rb->Format);
> -         gl_format dst_format = _mesa_get_srgb_format_linear(dst_rb->Format);
> -         if (src_format != dst_format) {
> -            perf_debug("glBlitFramebuffer(): unsupported blit from %s to %s.  "
> -                       "Falling back to software rendering.\n",
> -                       _mesa_get_format_name(src_format),
> -                       _mesa_get_format_name(dst_format));
> -            return mask;
> -         }
> -
>           if (!intel_miptree_blit(brw,
>                                   src_irb->mt,
>                                   src_irb->mt_level, src_irb->mt_layer,

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>