[Mesa-dev] [PATCH 41/42] i965/eu: introduce blorp specific flavour of lrp

Pohjolainen, Topi topi.pohjolainen at intel.com
Mon Jan 20 21:54:32 PST 2014


On Mon, Jan 20, 2014 at 08:11:06PM -0800, Paul Berry wrote:
>    On 20 December 2013 06:39, Topi Pohjolainen <topi.pohjolainen at intel.com>
>    wrote:
> 
>      This is rather ugly but as I couldn't think of anything better
>      for now and wanted to get the rest of the series under review,
>      I left it as it is.
>      Even though immediately surrounding code has tabs this piece is
>      written space-indented.
> 
>      Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> 
>    This patch is unnecessary.  The blorp specific "flavour" of lrp is
>    actually a previously undiscovered bug in blorp: blorp should be using
>    BRW_COMPRESSION_2NDHALF for its second half LRPs.  I believe the bug may
>    be benign, but we should fix it anyhow, and I think we can fix it by just
>    dropping this patch entirely.

Oh, very nice. Now it makes more sense.


More information about the mesa-dev mailing list