[Mesa-dev] [PATCH 1/2] i965/blorp: patch jump counters also for endif

Pohjolainen, Topi topi.pohjolainen at intel.com
Tue Jan 21 22:31:15 PST 2014


On Wed, Jan 22, 2014 at 06:57:28AM +0200, Pohjolainen, Topi wrote:
> On Tue, Jan 21, 2014 at 12:48:12PM -0800, Eric Anholt wrote:
> > Topi Pohjolainen <topi.pohjolainen at intel.com> writes:
> > 
> > > No known bugs fixed but this is now in line with fs-generator.
> > > No regresssions on IVB.
> > 
> > The endif jump, since it's forward, is just an optimization to have set
> > right -- otherwise, the GPU will just step forward instruction by
> > instruction until it hits something else that updates the per-channel
> > PC.
> 
> I'm glad you explained this, it was gnawing me a bit of not understanding
> the implication. Thanks!

I added your explanation as a quote in the commit message before pushing,
I hope you don't mind.

> 
> > 
> > Reviewed-by: Eric Anholt <eric at anholt.net>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list