[Mesa-dev] [PATCH] glsl: Add image type to the GLSL IR.

Francisco Jerez currojerez at riseup.net
Wed Jan 22 04:50:39 PST 2014


Paul Berry <stereotype441 at gmail.com> writes:

> On 15 January 2014 11:42, Francisco Jerez <currojerez at riseup.net> wrote:
>
>> v2: Reuse the glsl_sampler_dim enum for images.  Reuse the
>>     glsl_type::sampler_* fields instead of creating new ones specific
>>     to image types.  Reuse the same constructor as for samplers adding
>>     a new 'base_type' argument.
>> ---
>> Is this what you had in mind Paul?
>>
>
> Yes, that seems reasonable.  Thanks.

Does your previous reviewed-by still apply for v2 of this patch?

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140122/afb3fe5a/attachment.pgp>


More information about the mesa-dev mailing list