[Mesa-dev] [PATCH 1/4] radeon / r200: Fix incompatible pointer type warning

[Alex Deucher]

On Mon, Jan 20, 2014 at 2:26 PM, Ian Romanick <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> When parameters were removed from dd_function_table::Viewport (commit
> 065bd6ff), radeon_viewport (in both radeon and r200) started generating
> a warning.
>
> radeon_common.c: In function 'r200_radeon_viewport':
> radeon_common.c:415:15: warning: assignment from incompatible pointer type [enabled by default]
> radeon_common.c:419:23: warning: assignment from incompatible pointer type [enabled by default]
>
> I didn't notice this initially, and it's harmless because the function is
> never called through the incorrectly typed pointer.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Marek Olšák <marek.olsak at amd.com>

For the series:

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>


> ---
>  src/mesa/drivers/dri/radeon/radeon_common.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/radeon/radeon_common.c b/src/mesa/drivers/dri/radeon/radeon_common.c
> index 2df4388..5c2b823 100644
> --- a/src/mesa/drivers/dri/radeon/radeon_common.c
> +++ b/src/mesa/drivers/dri/radeon/radeon_common.c
> @@ -400,8 +400,7 @@ void radeon_viewport(struct gl_context *ctx)
>  {
>         radeonContextPtr radeon = RADEON_CONTEXT(ctx);
>         __DRIcontext *driContext = radeon->dri.context;
> -       void (*old_viewport)(struct gl_context *ctx, GLint x, GLint y,
> -                            GLsizei w, GLsizei h);
> +       void (*old_viewport)(struct gl_context *ctx);
>
>         if (_mesa_is_winsys_fbo(ctx->DrawBuffer)) {
>                 if (radeon->is_front_buffer_rendering) {
> --
> 1.8.1.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev