[Mesa-dev] [V3 PATCH 1/8] mesa: 's/\bgl_format\b/mesa_format/g'. Use better name for Mesa Formats enum

[Mark Mueller]

On Fri, Jan 17, 2014 at 8:58 AM, Brian Paul <brianp at vmware.com> wrote:

> On 01/16/2014 10:13 PM, Mark Mueller wrote:
>
>> This series encompases the much discussed specification and renaming of
>> MESA_FORMATs,
>> which now is packed into 8 patches
>>
>> Signed-off-by: Mark Mueller <MarkKMueller at gmail.com>
>> ---
>>
>
> Well, our other enum typedefs (and structs) all use the gl_ prefix.  But
> the other enum values don't use MESA_ prefixes so gl_formats are weird that
> way.  I'm kind on the fence about this change.
>
> -Brian
>
>
Obviously it's not critical, but the gl_ prefix is confusing because of the
weirdness, and Ken recommended a name change thus I took a stab at it. I've
left this change in V4 of the series. Would it be more convincing with a
different name, like mgl_formats, or mesa_gl_formats?

Mark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140122/f1f45a5c/attachment.html>