[Mesa-dev] [V3 PATCH 1/8] mesa: 's/\bgl_format\b/mesa_format/g'. Use better name for Mesa Formats enum

[Brian Paul]

On 01/22/2014 04:12 PM, Kenneth Graunke wrote:
> On 01/17/2014 08:58 AM, Brian Paul wrote:
>> On 01/16/2014 10:13 PM, Mark Mueller wrote:
>>> This series encompases the much discussed specification and renaming
>>> of MESA_FORMATs,
>>> which now is packed into 8 patches
>>>
>>> Signed-off-by: Mark Mueller <MarkKMueller at gmail.com>
>>> ---
>>
>> Well, our other enum typedefs (and structs) all use the gl_ prefix.  But
>> the other enum values don't use MESA_ prefixes so gl_formats are weird
>> that way.  I'm kind on the fence about this change.
>>
>> -Brian
>
> The formats are particularly confusing, though:
>
> There's code all over the place that deals with format information via
> GL enumeration values: GL_RGBA, GL_RGB10_A2UI, and so on.  There's also
> a ton of code that deals with MESA_FORMATs.
>
> When discussing new texture related code, the question "Are you using
> GL_* formats or gl_formats?" comes up in conversation a fair bit.

OK, I can definitely see how that would be confusing. :)

s/gl_format/mesa_format/ is fine.

-Brian