[Mesa-dev] [PATCH 01/15] i965: Pretend we don't support BRW_SURFACEFORMAT_R16G16B16_FLOAT for textures.

Chris Forbes chrisf at ijw.co.nz
Thu Jan 23 12:39:39 PST 2014


Oops -- there's junk in this commit message from before it was pulled
into this series.

On Tue, Jan 21, 2014 at 11:34 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:
> None of the other 3-component 16bpc formats are directly supported, so
> they get promoted to XRGB equivalents. *Not* promoting RGB16F the same
> way makes texture views much more fiddly -- we don't want to have to do
> crazy copying behind the scenes.
>
> (with my other master + my experimental ARB_texture_view support) fixes
> the piglit test: `spec/ARB_texture_view/view compare 48bit formats`
>
> No regressions in gpu.tests on Haswell.
>
> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
> ---
>  src/mesa/drivers/dri/i965/brw_surface_formats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c b/src/mesa/drivers/dri/i965/brw_surface_formats.c
> index 9b75c2b..e057926 100644
> --- a/src/mesa/drivers/dri/i965/brw_surface_formats.c
> +++ b/src/mesa/drivers/dri/i965/brw_surface_formats.c
> @@ -267,7 +267,7 @@ const struct surface_format_info surface_formats[] = {
>     SF( x,  x,  x,  x,  x,  x,  Y,  x,  x, BRW_SURFACEFORMAT_R64G64B64_FLOAT)
>     SF( Y,  Y,  x,  x,  x,  x,  x,  x,  x, BRW_SURFACEFORMAT_BC4_SNORM)
>     SF( Y,  Y,  x,  x,  x,  x,  x,  x,  x, BRW_SURFACEFORMAT_BC5_SNORM)
> -   SF(50, 50,  x,  x,  x,  x, 60,  x,  x, BRW_SURFACEFORMAT_R16G16B16_FLOAT)
> +   SF( x,  x,  x,  x,  x,  x, 60,  x,  x, BRW_SURFACEFORMAT_R16G16B16_FLOAT)
>     SF( x,  x,  x,  x,  x,  x,  Y,  x,  x, BRW_SURFACEFORMAT_R16G16B16_UNORM)
>     SF( x,  x,  x,  x,  x,  x,  Y,  x,  x, BRW_SURFACEFORMAT_R16G16B16_SNORM)
>     SF( x,  x,  x,  x,  x,  x,  Y,  x,  x, BRW_SURFACEFORMAT_R16G16B16_SSCALED)
> --
> 1.8.5.3
>


More information about the mesa-dev mailing list