[Mesa-dev] [PATCH 1/4] i965: Remove poorly implemented math hstride assertions.

Kenneth Graunke kenneth at whitecape.org
Thu Jan 23 13:13:21 PST 2014


I added this assertion in the last revision of the gen8_fs_generator
patch, and apparently didn't test it enough.  Many Piglit tests fail
this test.  The destination hstride is 1, while the source hstride and
vstride appear to be 0.  This sounds like "scalar source" mode, which is
actually supported.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/gen8_generator.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/gen8_generator.cpp b/src/mesa/drivers/dri/i965/gen8_generator.cpp
index ee5f792..8a79701 100644
--- a/src/mesa/drivers/dri/i965/gen8_generator.cpp
+++ b/src/mesa/drivers/dri/i965/gen8_generator.cpp
@@ -299,8 +299,6 @@ gen8_generator::math(unsigned math_function,
 {
    gen8_instruction *inst = next_inst(BRW_OPCODE_MATH);
 
-   assert(dst.hstride == src0.hstride);
-
    gen8_set_math_function(inst, math_function);
    gen8_set_dst(brw, inst, dst);
    gen8_set_src0(brw, inst, src0);
-- 
1.8.5.2



More information about the mesa-dev mailing list