[Mesa-dev] [PATCH] i965: Don't store qpitch / 4 as mt->qpitch for compressed surfaces.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> Broadwell requires software to specify QPitch in a bunch of packets,
> so we decided to store it in the miptree.  However, when I did that
> refactoring, I missed a subtlety: the hardware expects QPitch to be
> "in units of rows in the uncompressed surface".
>
> This is the value we originally compute.  However, for compressed
> surfaces, we then divided it by 4 (the block height), to obtain the
> physical layout.  This is no longer the QPitch Broadwell expects.
>
> So, store the original undivided value in mt->qpitch, but continue to
> use the divided value in brw_miptree_layout_texture_array().  For
> non-Broadwell platforms, this should have no impact at all.
>
> Helps fix Piglit's "getteximage-targets S3TC CUBE" test on Broadwell.

I'd noted this in the original review that led to saving qpitch in
the miptree. :/

Reviewed-by: Eric Anholt <eric at anholt.net>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140123/1f62bf9f/attachment.pgp>